Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete IPC overhaul #31

Merged
merged 16 commits into from
Jun 28, 2024
Merged

Complete IPC overhaul #31

merged 16 commits into from
Jun 28, 2024

Conversation

Day-OS
Copy link
Contributor

@Day-OS Day-OS commented Jun 28, 2024

Deep Station 14 Pull Request

About the PR

This is a complete overhaul of IPCs that changes the current IPCs of Deep Station 14 to the IPCs from the brazilian server Estação Pirata.
It comes initially from a commit from ParkStation (see: Simple-Station/Parkstation#97), as it is where they initially came from, and then starts pilling up Estação Pirata's modifications.

Why / Balance

Most of the changes that were made from the IPCs from park are listed bellow:

  • Repairs by welders are made in a doafter loop so they are less annoying.
  • IPCs uses wizden-flavored borgs chargers
  • IPCs can use a limited set of masks
  • IPCs can wear glasses
  • IPCs can be blinded
  • IPCs have custom made emote sounds
  • There's an entire guide about repairing them
  • IPCs are targeted more easily by tesla beams
  • IPCs have a reboot interaction button when they are dead
  • IPCs emits energy beams, draining its battery, when it gets electrocuted while they are dead (just so people turn them on with the reboot button instead of ELECTROCUTING them)
  • IPCs emits sparkles when they are very damaged
  • IPCs have an entire new way of getting repaired, that is, by welding them, replacing their cables and giving them new lenses (see guide for more)
  • IPCs have entire new body marking parts for extra customization, just like the good old days in ss13... Oh, did I mention other species get some of those parts too? (arms and legs)

Technical details

It removes the current DeepStation IPCs and replaces it with the Pirata's one.

Media

So, many of the features presented here are also in the Estação Pirata. so some videos presented here are recorded from there and it is only to show how the features work. They are unfortunately in portuguese, but I think it can give the idea of how it works.

Narrated (PORTUGUESE) Repair overhaul DEMO

Yes... I know... it would be better if it was in english... Sorry...

2024-04-10_22-04-33.mp4

Welders DoAfter Loop

2024-04-10_23-28-58.mp4

Turn on button + Repair overhaul (cables for burn damage):

2024-06-11_18-44-59.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Day-OS and others added 13 commits June 27, 2024 20:52
@Day-OS @DEATHB4DEFEAT
[Species] InterPersonal Conflict
8ba8e35 
Co-Authored-By: DEATHB4DEFEAT <[email protected]>
@Day-OS
[Species] IPC conversion
ef53ac2 
- Changes recharging system to match with wizden borgs chargers.
- Makes IPCs be able to take damage from EMPs and being stunned.
- Reduces weld repair time
- adds a message (ipc-recharge-tip) when the IPC is being recharged by an APC (that makes the system less confusing)
- Changes screen marking slots to be HeadSide instead of "Beard"
- Changes antennas marking slots to be HeadTop instead of Hairs
- Fixes broken zoom from IPCs
- Fixes EncryptionKeys not being added at the start of the round
- Turn IPCs able to get hugs (Machines deserve love too!)
- Removes beards from IPCs
@Day-OS
Some IPCs fixes (list in desc)
cb4f809 
- Make IPCs blind when using welding tools (cameras are as blindable as eyes).
- Fix some IPC emote sounds
- Change IPC sounds to simple robotic sounds (just to remove the human sounds).
- Allow IPCs to wear glasses.
- Provide a guide to avoid future headaches.
- Unify positronic brains (borgs and IPCs).
- Overhaul the IPCs parent "PlayerSiliconHumanoidBase" entity
- Remove IPCs blood
- Turns IPCs priority targets to Tesla beams.
- Adjust liquid inside of IPCs
- Add new sound effects for IPC emotes.
- Makes EyeDamage be cured to IPCs when repaired.
- Adds a note on repairing IPCs at the end of the guide.
- Adds additional colors to certain parts of the guide to find keywords more easily.
- Fix IPCs talking while dead.
- Fixes (in a lazy way) the issue of IPCs leaving absolutely NO trace by adding fingerprint component
- Adjusts keySlots from 3 to 4
@Arctic-Husky @Day-OS
Adds Buzzing system to silicons that are in critical state
810f923
@Day-OS
Fixes IPC Locker
32d8d9a 
- Fixes Locker
- Adds lockTIme
- Adjusts battery slot to start locked
- Fixes Encryption keys appearing while the locker is closed
@Day-OS
IPC Repair Overhaul
1d95833 
- Complete Overhaul inspired in some ss13 codes like ParadiseStation

- Updates IPC guide
@Day-OS
Fix IPCs not overheating
dcff051
@Day-OS
Rework of IPC death mechanics
39c495d 
This (amostly) solves all the issues of IPCs needing to be fixed using a Defibrilator.

It makes so the repairer just needs to press a single button to restart the IPC's system.

Update ipc.yml
@Day-OS
Adds cybernetic limbs (MARKINGS) for IPCs and some parts for other sp…
1955ba8 
…ecies
@Day-OS
Turns Cyberlimbs (Markings) RGB compatible
21adf26
@Day-OS
Turns IPCs capable of wearing SOME masks
b414241
@Day-OS
Fixes IPCs being unable to have Guardians
79180cd 
I mean, Guardians are not necessarily a Stand, so machines could be haunted aswell by them.

Does it really matter though? ORAORAORAORAORAORAORA
@Day-OS
Fixes IntegrationTests errors related to IPC
43d6b7e
@github-actions GitHub Actions
Copy link
Contributor

Thank you for contributing to our repository. Unfortunately, it looks like you submitted your pull request from the master branch. We suggest you follow the git usage documentation.

You can move your current work from the master branch to another branch by branching from and resetting the master branch.

@github-actions github-actions bot closed this Jun 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 28, 2024 •
edited
Loading

RSI Diff Bot; head commit ac00175 merging into 5d41580
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Mobs/Species/IPCs/organs.rsi

State Old New Status
posibrain Removed

Resources/Textures/Mobs/Species/IPCs/parts.rsi

State Old New Status
chest Removed
full Removed
head Removed
l_arm Removed
l_foot Removed
l_hand Removed
l_leg Removed
r_arm Removed
r_foot Removed
r_hand Removed
r_leg Removed

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/bishop/bishop_alt1.rsi

State Old New Status
head Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/bishop/bishop_main.rsi

State Old New Status
head Added
l_arm-primary Added
l_arm-secondary Added
l_arm-tertiary Added
l_foot Added
l_hand Added
l_leg-primary Added
l_leg-secondary Added
r_arm-primary Added
r_arm-secondary Added
r_arm-tertiary Added
r_foot Added
r_hand Added
r_leg-primary Added
r_leg-secondary Added
torso-primary Added
torso-secondary Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/bishop/bishop_monitor.rsi

State Old New Status
head-2 Added
head Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/hesphiastos/hesphiastos_alt1.rsi

State Old New Status
head Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/hesphiastos/hesphiastos_main.rsi

State Old New Status
l_arm-1 Added
l_arm-2 Added
l_foot-1 Added
l_foot-2 Added
l_hand-1 Added
l_hand-2 Added
l_leg-1 Added
l_leg-2 Added
r_arm-1 Added
r_arm-2 Added
r_foot-1 Added
r_foot-2 Added
r_hand-1 Added
r_hand-2 Added
r_leg-1 Added
r_leg-2 Added
torso-1 Added
torso-2 Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/hesphiastos/hesphiastos_monitor.rsi

State Old New Status
head-1 Added
head-2 Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/morpheus/morpheus_alt1.rsi

State Old New Status
head Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/morpheus/morpheus_main.rsi

State Old New Status
head Added
l_arm Added
l_foot Added
l_hand Added
l_leg Added
r_arm Added
r_foot Added
r_hand Added
r_leg Added
torso Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/shellguard/shellguard_alt1.rsi

State Old New Status
head Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/shellguard/shellguard_main.rsi

State Old New Status
l_arm-1 Added
l_arm-2 Added
l_foot-1 Added
l_foot-2 Added
l_hand-1 Added
l_hand-2 Added
l_leg-1 Added
l_leg-2 Added
r_arm-1 Added
r_arm-2 Added
r_foot-1 Added
r_foot-2 Added
r_hand-1 Added
r_hand-2 Added
r_leg-1 Added
r_leg-2 Added
torso-1 Added
torso-2 Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/shellguard/shellguard_monitor.rsi

State Old New Status
head-1 Added
head-2 Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/wardtakahashi/wardtakahashi_alt1.rsi

State Old New Status
head Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/wardtakahashi/wardtakahashi_main.rsi

State Old New Status
head Added
l_arm Added
l_foot Added
l_hand Added
l_leg Added
r_arm Added
r_foot Added
r_hand Added
r_leg Added
torso Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/wardtakahashi/wardtakahashi_monitor.rsi

State Old New Status
head Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/xion/xion_alt1.rsi

State Old New Status
head Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/xion/xion_main.rsi

State Old New Status
l_arm-1 Added
l_arm-2 Added
l_foot-1 Added
l_foot-2 Added
l_hand-1 Added
l_hand-2 Added
l_leg-1 Added
l_leg-2 Added
r_arm-1 Added
r_arm-2 Added
r_foot-1 Added
r_foot-2 Added
r_hand-1 Added
r_hand-2 Added
r_leg-1 Added
r_leg-2 Added
torso-1 Added
torso-2 Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/xion/xion_monitor.rsi

State Old New Status
head-1 Added
head-2 Added

Resources/Textures/EstacaoPirata/Mobs/Customization/cyberlimbs/zenghu/zenghu_main.rsi

State Old New Status
groin Added
head Added
l_arm Added
l_foot Added
l_hand Added
l_leg Added
r_arm Added
r_foot Added
r_hand Added
r_leg Added
torso Added

Resources/Textures/SimpleStation14/Interface/Alerts/charge.rsi

State Old New Status
charge-empty Added
charge0 Added
charge1 Added
charge2 Added
charge3 Added
charge4 Added

Resources/Textures/SimpleStation14/Mobs/Customization/ipc_antenna.rsi

State Old New Status
ipc_antenna_antlers Added
ipc_antenna_crowned Added
ipc_antenna_cyberhead Added
ipc_antenna_droneeyes Added
ipc_antenna_light Added
ipc_antenna_lightb Added
ipc_antenna_sidelights Added
ipc_antenna_tesla Added
ipc_antenna_towers Added
ipc_antenna_tv Added

Resources/Textures/SimpleStation14/Mobs/Customization/ipc_screens.rsi

State Old New Status
ipc_screen_blank Added
ipc_screen_blue Added
ipc_screen_breakout Added
ipc_screen_bsod Added
ipc_screen_console Added
ipc_screen_ecgwave Added
ipc_screen_eight Added
ipc_screen_exclaim Added
ipc_screen_eyes Added
ipc_screen_eyesangry Added
ipc_screen_eyestall Added
ipc_screen_frown Added
ipc_screen_glider Added
ipc_screen_goggles Added
ipc_screen_heart Added
ipc_screen_l Added
ipc_screen_loading Added
ipc_screen_monoeye Added
ipc_screen_nature Added

Edit: diff updated after ac00175

@Peptide90 Peptide90 reopened this Jun 28, 2024
@Peptide90 Peptide90 merged commit b3b16ff into SS14-Classic:master Jun 28, 2024
11 of 13 checks passed
@Mnemotechnician
Copy link
Contributor

This does not define a LanguageKnowledgeComponent for IPCs, which makes the system default to Universal, but since they do not have a UniversalLanguageSpeakerComponent either, they can only speak universal (i.e. everyone else understands them), but cannot understand anyone else

@Day-OS
Copy link
Contributor Author

Day-OS commented Jun 30, 2024

This does not define a LanguageKnowledgeComponent for IPCs, which makes the system default to Universal, but since they do not have a UniversalLanguageSpeakerComponent either, they can only speak universal (i.e. everyone else understands them), but cannot understand anyone else

I'm really sorry about that, the IPC came from a wizden downstream server, so languages aren't a thing there.

Thanks for making it clear for me.
Then again, I'm really sorry for that. Any more reports are gracelly appreciated!

@Timemaster99 Timemaster99 mentioned this pull request Jul 10, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Changes: Audio Changes: C# Changes: Documentation Changes: Localization Changes: Sprite Changes: YML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Day-OS @Mnemotechnician @Peptide90 @Arctic-Husky @DEATHB4DEFEAT